From 2000278f1a1471312d608bbaa1ce932b287f40c8 Mon Sep 17 00:00:00 2001
From: kasun <kasun.jayatilaka@gmail.com>
Date: Wed, 8 Apr 2026 20:51:14 +0200
Subject: [PATCH] got rid if Map and added username, password and apikey to
 request body

---
 .../app/connection/HomeBoxConnectionProvider.java    |  6 +++---
 .../java/com/vaessl/app/dto/ConnectionRequest.java   | 12 ++++++++----
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/backend/src/main/java/com/vaessl/app/connection/HomeBoxConnectionProvider.java b/backend/src/main/java/com/vaessl/app/connection/HomeBoxConnectionProvider.java
index c8fc2d3..fa7117f 100644
--- a/backend/src/main/java/com/vaessl/app/connection/HomeBoxConnectionProvider.java
+++ b/backend/src/main/java/com/vaessl/app/connection/HomeBoxConnectionProvider.java
@@ -31,8 +31,8 @@ public class HomeBoxConnectionProvider implements ConnectionProvider {
 
     @Override
     public ConnectionResponse authenticate(ConnectionRequest request) {
-        Map<String, Object> homeboxPayload = Map.of("username", request.credentials().get("username"),
-                "password", request.credentials().get("password"), "stayLoggedIn",
+        Map<String, Object> homeboxPayload = Map.of("username", request.username(),
+                "password", request.password(), "stayLoggedIn",
                 request.stayLoggedIn());
 
         HomeboxLoginResponse hbResponse = restClientBuilder.baseUrl(request.appUrl())
@@ -57,7 +57,7 @@ public class HomeBoxConnectionProvider implements ConnectionProvider {
     @Override
     public ConnectionEntity findUniqueConnectionEntry(ConnectionRequest request) {
 
-        return cRepository.findByAppUrlAndUsername(request.appUrl(), request.credentials().get("username"));
+        return cRepository.findByAppUrlAndUsername(request.appUrl(), request.username());
     }
 
     @Override
diff --git a/backend/src/main/java/com/vaessl/app/dto/ConnectionRequest.java b/backend/src/main/java/com/vaessl/app/dto/ConnectionRequest.java
index 587a94b..3c6272d 100644
--- a/backend/src/main/java/com/vaessl/app/dto/ConnectionRequest.java
+++ b/backend/src/main/java/com/vaessl/app/dto/ConnectionRequest.java
@@ -1,16 +1,15 @@
 package com.vaessl.app.dto;
 
-import java.util.Map;
-
 import com.fasterxml.jackson.annotation.JsonProperty;
 
 import jakarta.validation.constraints.NotBlank;
-import jakarta.validation.constraints.NotEmpty;
 
 public record ConnectionRequest(
                 @NotBlank(message = "App URL is mandatory") String appUrl,
                 @NotBlank(message = "Service type is mandatory") String serviceType,
-                @NotEmpty(message = "Credentials are mandatory") Map<String, String> credentials,
+                String username,
+                String password,
+                String apiKey,
                 @JsonProperty(defaultValue = "false") Boolean stayLoggedIn) {
 
         public ConnectionRequest {
@@ -18,4 +17,9 @@ public record ConnectionRequest(
                         stayLoggedIn = false;
                 }
         }
+
+        public ConnectionRequest(String appUrl, String serviceType, String username, String password,
+                        Boolean stayLoggedIn) {
+                this(appUrl, serviceType, username, password, null, stayLoggedIn);
+        }
 }